-
Notifications
You must be signed in to change notification settings - Fork 235
feat: add JAX as Computation Backend #1646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1aef069 to
fdcbe92
Compare
samsja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks mostly good ! Once we have :
- DocVec working
- Integration test
we will be good to go
a679638 to
83a2b9b
Compare
samsja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good. I added some tiny comments.
We are just missing the interagration test before we merge !
|
btw looking at the CI it seems that you still have place where you load jax without using the helper import and therefore it throw an error |
|
Hey @agaraman0 , would it be possible for you to add a code snippet as an example of the usage of this feature in the PR description. Like this we can add it in future release notes to highlight this awesome feature. |
Sure will do that, I am just looking for some existing example if I can replicate one. |
92e32ec to
6b57436
Compare
Signed-off-by: agaraman0 <[email protected]>
Signed-off-by: agaraman0 <[email protected]>
Signed-off-by: agaraman0 <[email protected]>
Signed-off-by: agaraman0 <[email protected]>
Signed-off-by: agaraman0 <[email protected]>
Signed-off-by: agaraman0 <[email protected]>
Signed-off-by: agaraman0 <[email protected]>
Signed-off-by: agaraman0 <[email protected]>
Signed-off-by: agaraman0 <[email protected]>
|
@agaraman0 can you add an equivalent test to the one added for Pytorch and TF in this PR #1696 |
Signed-off-by: agaraman0 <[email protected]>
scott-martens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I found all docstrings. A few changes recommended.
Signed-off-by: agaraman0 <[email protected]>
Signed-off-by: agaraman0 <[email protected]>
Signed-off-by: agaraman0 <[email protected]>
Signed-off-by: agaraman0 <[email protected]>
Signed-off-by: agaraman0 <[email protected]>
Signed-off-by: agaraman0 <[email protected]>
Signed-off-by: agaraman0 <[email protected]>
Signed-off-by: agaraman0 <[email protected]>
samsja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR looking forward to merge
Integrating JAX as a computation backend in Docarray similar to Pytorch, Tensorflow, and Numpy
JaxArraytyping implementationJaxArraytyping unit testsJaxCompBackendmethods implementationJaxCompBackendbasic testsDocVecworking