fix: mypy and unit tests

Signed-off-by: Mohammad Kalim Akram <[email protected]>
docarray · jupyterjazz · Jun 26, 2023 · May 31, 2023 · Jun 22, 2023 · Jun 23, 2023
commit a7f515d1658d389546f831c9632bf9d742b22601
diff --git a/docarray/typing/url/any_url.py b/docarray/typing/url/any_url.py
@@ -51,15 +51,15 @@ def _to_node_protobuf(self) -> 'NodeProto':
         return NodeProto(text=str(self), type=self._proto_type_name)
 
     @classmethod
-    def is_extension_allowed(cls, value: 'AnyUrl') -> bool:
+    def is_extension_allowed(cls, value: Any) -> bool:
         """
         Check if the file extension of the url is allowed for that class.
         First read the mime type of the file, if it fails, then check the file extension.
 
         :param value: url to the file
         :return: True if the extension is allowed, False otherwise
         """
-        if not issubclass(cls, AnyUrl):  # no check for AnyUrl class
+        if cls == AnyUrl:  # no check for AnyUrl class
             return True
         mimetype, _ = mimetypes.guess_type(value.split("?")[0])
         if mimetype:
@@ -72,7 +72,7 @@ def is_extension_allowed(cls, value: 'AnyUrl') -> bool:
             )
 
     @classmethod
-    def is_special_case(cls, value: 'AnyUrl') -> bool:
+    def is_special_case(cls, value: Any) -> bool:
         """
         Check if the url is a special case.
 
@@ -105,8 +105,8 @@ def validate(
         url = super().validate(abs_path, field, config)  # basic url validation
 
         # perform check only for subclasses of AnyUrl
-        if not cls.is_extension_allowed(url):
-            if not cls.is_special_case(url):  # check for special cases
+        if not cls.is_extension_allowed(value):
+            if not cls.is_special_case(value):  # check for special cases
                 raise ValueError(
                     f'file {value} is not a valid file format for class {cls}'
                 )

diff --git a/docarray/typing/url/text_url.py b/docarray/typing/url/text_url.py
@@ -37,6 +37,7 @@ def is_special_case(cls, value: 'AnyUrl') -> bool:
                 # This handles the case where the value is a URL without a file extension
                 # for e.g. https://de.wikipedia.org/wiki/Brixen
                 return True
+        return False
 
     def load(self, charset: str = 'utf-8', timeout: Optional[float] = None) -> str:
         """

diff --git a/tests/index/weaviate/test_index_get_del_weaviate.py b/tests/index/weaviate/test_index_get_del_weaviate.py
@@ -403,7 +403,7 @@ class MyMultiModalDoc(BaseDoc):
 
 
 def test_index_document_with_bytes(weaviate_client):
-    doc = ImageDoc(id="1", url="www.foo.com", bytes_=b"foo")
+    doc = ImageDoc(id="1", url="www.foo.com/test.png", bytes_=b"foo")
 
     index = WeaviateDocumentIndex[ImageDoc]()
     index.index([doc])

diff --git a/tests/integrations/predefined_document/test_audio.py b/tests/integrations/predefined_document/test_audio.py
@@ -29,7 +29,6 @@
     str(TOYDATA_DIR / 'hello.ogg'),
     str(TOYDATA_DIR / 'hello.wma'),
     str(TOYDATA_DIR / 'hello.aac'),
-    str(TOYDATA_DIR / 'hello'),
 ]
 
 LOCAL_AUDIO_FILES_AND_FORMAT = [
@@ -40,7 +39,6 @@
     (str(TOYDATA_DIR / 'hello.ogg'), 'ogg'),
     (str(TOYDATA_DIR / 'hello.wma'), 'asf'),
     (str(TOYDATA_DIR / 'hello.aac'), 'adts'),
-    (str(TOYDATA_DIR / 'hello'), 'wav'),
 ]
 
 NON_AUDIO_FILES = [