-
Notifications
You must be signed in to change notification settings - Fork 8.7k
FEATURE: Allow users to publicly share their Rewind reports #36587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
martin-brennan
wants to merge
15
commits into
main
Choose a base branch
from
feature/rewind-share
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4fb1e46 to
10640a4
Compare
10640a4 to
9268969
Compare
ZogStriP
reviewed
Dec 11, 2025
plugins/discourse-rewind/app/controllers/discourse_rewind/rewinds_controller.rb
Show resolved
Hide resolved
ZogStriP
reviewed
Dec 11, 2025
ZogStriP
reviewed
Dec 11, 2025
ZogStriP
approved these changes
Dec 11, 2025
Contributor
|
does "publicly" mean just with other logged in users? or if the site itself is public, does that also make it accessible to anon visitors? If it's just logged in users, maybe we replace "publicly" with "with other members of this community" |
jjaffeux
reviewed
Dec 11, 2025
plugins/discourse-rewind/assets/javascripts/discourse/components/rewind.gjs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@mcwumbly just logged-in users, will update the copy |
Also add more specs and fix copy for sharing because it's not actually publiclly
Contributor
Author
|
Will merge this Monday after @awesomerobot takes a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows users to share their Rewind report publicly,
and allows all admins to see everyone's Rewind report regardless
of sharing settings.
Users who want to share or unshare their rewind publicly
do it here:
A confirmation is shown:
Other users who cannot see the rewind will see an error like this:
We always show this message when viewing another user's Rewind:
Users can also unshare their rewind from rewind preferences: