[bug-fix] Function get_entry_property() is not expecting a None entry, leading to TypeError: 'NoneType' object is not subscriptable #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found a bug in the
get_entry_propertyfunction when aNoneTypeentry is passed:The problem takes its source here, the SID resolution can return
None:Then the value cascades into the
resolve_ad_entry()function, which callsget_entry_property(). Asget_entry_property()is not expecting aNoneentry, it crashes and breaks the whole process.Fixed in this pull request
Best regards,