Store avatars in the user's cache directory. #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add some code that looks whether the old avatar folder exists (and the new folder doesn't exist), and if so, moves the old folder to the new location? And if both exist, just remove the old one. This could go into the constructor of the AvatarManager, before creating the new folder. |
eerielili
force-pushed
the
dot-cache-avatars
branch
2 times, most recently
from
fd474ae
to
6496730
Compare
|
@fiaxh Done. I tried to be compatible with https://specifications.freedesktop.org/trash-spec/latest/ and if not supported, fall back with GLib. |
- Not anymore in ~/.local/share, where media files are stored. - Already existing ~/.local/share/dino/avatars directory will be moved to ~/.cache/dino/avatars - If both directories already exists, the old one (in ~/.local/share) is removed.
eerielili
force-pushed
the
dot-cache-avatars
branch
from
6496730
to
e00a6b4
Compare
|
Force-pushed just now: I made the IOError message on recursive deletion less obtuse if it occurs. |
|
I think we can just remove the old folder, and don't have to move it to trash, as the data is recoverable. Also, the avatars folder shouldn't contain other folders. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1615.
Moreover, this commit separating volatile and less critical media files (avatars in
~/.cache) and important ones (in~/.local/share/files) will make Dino fit more nicely with the FreeDesktop specifications :