Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcut to show preferences #1435

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

eerielili
Copy link
Contributor

Addresses #145

@fiaxh
Copy link
Member

fiaxh commented Oct 8, 2023

I looked a bit into what other applications do. It seems to be common to use Ctrl+, as a shortcut to open the preferences. Thus, I think we should do the same.

@eerielili eerielili closed this Oct 8, 2023
@eerielili eerielili force-pushed the add-kbd-shortcut-to-show-settings branch from 8f64348 to 86b1019 Compare October 8, 2023 16:06
@eerielili eerielili reopened this Oct 8, 2023
@eerielili
Copy link
Contributor Author

@fiaxh Okay, I corrected the shortcut trigger and updated my branch.

@fiaxh fiaxh force-pushed the add-kbd-shortcut-to-show-settings branch from f23874e to 6220b91 Compare September 22, 2024 11:24
@fiaxh fiaxh merged commit d20553a into dino:master Sep 22, 2024
3 checks passed
@fiaxh
Copy link
Member

fiaxh commented Sep 22, 2024

Thanks and sorry for only getting back to this now.

@eerielili
Copy link
Contributor Author

@fiaxh No problem. Better late than never!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants