accept standard hlists as record/variant specs #14167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG_BEGIN CHANGELOG_END
S11001001
added
component/daml-lf
4 tasks
S11001001
requested review from
ray-roestenburg-da and
remyhaemmerle-da
as code owners
daml-lf/transaction-test-lib/src/main/scala/lf/value/test/TypedValueGenerators.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Raymond Roestenburg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10827, among other things, made it possible to create record and variant type specs for
TypedValueGeneratorswith ordinary hlists instead of theRNilandRecVarSpecexplicit steps, because it avoids scala/bug#5075, which was fatal to previous attempts to do this.That in turn makes it possible to use the keyword-arg record macro to write specs instead of the older
->>record syntax. A good motivating example is at the top ofHashSpecin this PR.#14189 is a followup to port the remaining specs to the new syntax. This also aids with #13356, as the idea is for more records to be generated from
TypedValueGeneratorsspecs, which calls for those specs to be written in a nicer and more natural format provided here.