Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release v20.03.1 #156

Merged
merged 3 commits into from
Aug 10, 2020
Merged

chore: release v20.03.1 #156

merged 3 commits into from
Aug 10, 2020

Conversation

abhimanyusinghgaur
Copy link
Contributor

@abhimanyusinghgaur abhimanyusinghgaur commented Aug 10, 2020 •
edited by manishrjain
Loading

This change is Reviewable

danielmai
danielmai reviewed Aug 10, 2020
View reviewed changes
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we make a change so that dgraph4j only works with v20.07.0 or later? These are the client versioning rules from the blog:

If the July release only breaks a particular client, we will only release that client. If the Dgraph version 20.07.0 has client API changes, then the client library version will be 20.07.0. Any client libraries not affected will remain as 20.03.0, indicating they are compatible with both March and July releases.

If the client still works with v20.03.0, then the new version should still be under the v20.03.x series.

Reviewable status: 0 of 6 files reviewed, all discussions resolved

@abhimanyusinghgaur abhimanyusinghgaur changed the title chore: release v20.07.0 chore: release v20.03.1 Aug 10, 2020
@abhimanyusinghgaur
Copy link
Contributor Author

Thanks @danielmai.
I did make a mistake, I had published dgraph4j 20.07.0 on maven. I will take that down, and publish the new version 20.03.1.

danielmai
danielmai approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@abhimanyusinghgaur abhimanyusinghgaur merged commit efd31f9 into master Aug 10, 2020
@abhimanyusinghgaur abhimanyusinghgaur deleted the abhimanyu/release-v20.07 branch August 10, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmai danielmai danielmai approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhimanyusinghgaur @danielmai