-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for creating a secure client #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mangalaman93, @martinmr, and @sleto-it)
README.md, line 100 at r1 (raw file):
Creating a Secure Client using TLS
Add a link to the docs about TLS setup. Is adding a trust manager only needed for self-signed certs?
dbca319
to
fc79c4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after fixing Daniel's comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mangalaman93 and @sleto-it)
fc79c4b
to
412aa2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @danielmai, @martinmr, and @sleto-it)
README.md, line 100 at r1 (raw file):
Previously, danielmai (Daniel Mai) wrote…
Add a link to the docs about TLS setup. Is adding a trust manager only needed for self-signed certs?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @danielmai, @mangalaman93, @martinmr, and @sleto-it)
README.md, line 108 at r3 (raw file):
```java SslContextBuilder builder = GrpcSslContexts.forClient(); builder.trustManager(new File("<path to ca.crt>"));
You might want to mention. The CA.crt is the CA that signed the "server" certificate. If the server certificate is self-signed, then the server's certificate goes in here.
412aa2c
to
85cfd64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @danielmai, @martinmr, @parasssh, and @sleto-it)
README.md, line 108 at r3 (raw file):
Previously, parasssh wrote…
You might want to mention. The CA.crt is the CA that signed the "server" certificate. If the server certificate is self-signed, then the server's certificate goes in here.
The way instructions are provided in the https://docs.dgraph.io/deploy/#tls-configuration, we generally use self signed certificate. We don't have a way to get the certificate signed from an external CA yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #123
This change is