Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add japanese locale #69

Merged
merged 1 commit into from
Jan 12, 2019
Merged

Add japanese locale #69

merged 1 commit into from
Jan 12, 2019

Conversation

tsukakei
Copy link
Contributor

Dear maintainers,

I'd like you to add Japanese locale to your great work.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 194

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 92.371%
Totals Coverage Status
Change from base Build 190: 0.008%
Covered Lines: 896
Relevant Lines: 970
💛 - Coveralls

7 similar comments
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 194

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 92.371%
Totals Coverage Status
Change from base Build 190: 0.008%
Covered Lines: 896
Relevant Lines: 970
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 194

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 92.371%
Totals Coverage Status
Change from base Build 190: 0.008%
Covered Lines: 896
Relevant Lines: 970
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 194

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 92.371%
Totals Coverage Status
Change from base Build 190: 0.008%
Covered Lines: 896
Relevant Lines: 970
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 194

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 92.371%
Totals Coverage Status
Change from base Build 190: 0.008%
Covered Lines: 896
Relevant Lines: 970
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 194

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 92.371%
Totals Coverage Status
Change from base Build 190: 0.008%
Covered Lines: 896
Relevant Lines: 970
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 194

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 92.371%
Totals Coverage Status
Change from base Build 190: 0.008%
Covered Lines: 896
Relevant Lines: 970
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Dec 27, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 194

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 92.371%
Totals Coverage Status
Change from base Build 190: 0.008%
Covered Lines: 896
Relevant Lines: 970
💛 - Coveralls

@olbrich olbrich added this to the Next Release milestone Dec 27, 2018
@olbrich
Copy link
Contributor

olbrich commented Dec 27, 2018

@tsukakei Thank you for your contribution!

@olbrich olbrich merged commit 9a716ef into devise-security:master Jan 12, 2019
@olbrich olbrich added the #️⃣.#️⃣ Minor added functionality in a backwards-compatible manner label Jan 13, 2019
itsmechlark pushed a commit to itsmechlark/devise-security that referenced this pull request Feb 2, 2019
@tsukakei
chore: add japanese locale (devise-security#69)
f37847e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olbrich olbrich olbrich approved these changes

Assignees
No one assigned
Labels
#️⃣.#️⃣ Minor added functionality in a backwards-compatible manner ✨ enhancement
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tsukakei @coveralls @olbrich