Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default ruby version & add codeclimate configs #47

Merged
merged 4 commits into from
Sep 4, 2018
Merged

Update default ruby version & add codeclimate configs #47

merged 4 commits into from
Sep 4, 2018

Conversation

olbrich
Copy link
Contributor

@olbrich olbrich commented Aug 29, 2018

  • Move default ruby version to 2.3.7 since 2.2.9 is no longer supported
  • update dependencies for minitest
  • add codeclimate config

@olbrich olbrich added this to the Next Release milestone Aug 29, 2018
@olbrich olbrich self-assigned this Aug 29, 2018
@coveralls
Copy link
Collaborator

coveralls commented Aug 29, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 138

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.03%) to 88.918%
Files with Coverage Reduction New Missed Lines %
lib/devise-security/controllers/helpers.rb 1 50.94%
test/test_password_expired_controller.rb 1 100.0%
lib/devise-security/rails.rb 2 100.0%
test/test_security_question_controller.rb 3 100.0%
Totals Coverage Status
Change from base Build 135: -0.03%
Covered Lines: 690
Relevant Lines: 776
💛 - Coveralls

@olbrich olbrich merged commit f0454e4 into devise-security:master Sep 4, 2018
olbrich added a commit to olbrich/devise-security that referenced this pull request Sep 4, 2018
@olbrich
Update default ruby version & add codeclimate configs (devise-securit…
1feee9d 
…y#47)

* update default ruby version
* add codeclimate config
olbrich added a commit that referenced this pull request Oct 13, 2018
@olbrich
Refactor Password Expireable (#45)
96bfdd8 
* Improved documentation for devise-security initializer configuration
* Update default ruby version & add codeclimate configs (#47)
* refactor password_expirable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebird natebird natebird approved these changes

@dillonwelch dillonwelch Awaiting requested review from dillonwelch

Assignees

@olbrich olbrich

Labels
✨ enhancement
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@olbrich @coveralls @natebird