Drop Rails 4.2 support #300
Conversation
olbrich
added
⬆️ dependencies
| jobs: | ||
| run-tests: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| orm: [active_record, mongoid] | ||
| rails: ['4.2', '5.0', '5.1', '5.2', '6.0'] |
There was a problem hiding this comment.
Dropping 4.2 here and from conditionals is the major change here
There was a problem hiding this comment.
LOVE IT!
One small thing I think we can clean up:
Since we aren't using Mongoid.4 anymore (since that was for Rails 4.2), we can get rid of the conditionals in these two files.
https://github.com/devise-security/devise-security/blob/f2d3fe8a4a2a28bc6764b6c3b437e3887cb4ebe0/test/dummy/config/mongoid.yml
https://github.com/devise-security/devise-security/blob/f2d3fe8a4a2a28bc6764b6c3b437e3887cb4ebe0/test/support/mongoid.yml
- Drops conditional handling of Rails versions < 5.0 Fixes devise-security#202
olbrich
force-pushed
the
olbrich/issue202
branch
from
c510639 to
193cffb
Compare
Co-authored-by: Dillon Welch <[email protected]>
| end | ||
|
|
||
| group :mongoid do | ||
| gem 'mongoid' | ||
| gem 'mongoid', '~> 6.0' |
There was a problem hiding this comment.
Curious about why we need to specify a version here
| <%= Mongoid::VERSION.to_i > 4 ? 'clients' : 'sessions' %>: | ||
| clients: |
There was a problem hiding this comment.
Is this why we specify mongoid to be version 6 in our base Gemfil?
Fixes #202