Skip to content

Drop ruby 2.4 support #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2020
Merged

Drop ruby 2.4 support #189

merged 2 commits into from
Apr 23, 2020

Conversation

olbrich
Copy link
Contributor

@olbrich olbrich commented Apr 16, 2020 •
edited
Loading

Ruby 2.4 support ended April 5, 2020

Co-authored-by: Troy Rosenberg [email protected]
Co-authored-by: Sam Neely [email protected]
@cholt2912

@olbrich @tmr08c
Drop ruby 2.4 support
64ad1a9 
Co-authored-by: Troy Rosenberg <[email protected]>
Co-authored-by: Sam Neely <[email protected]>
@olbrich olbrich added ⬆️ dependencies Pull requests that update a dependency file 🏗️ maintenance #️⃣.#️⃣.#️⃣ Patch backwards-compatible bug fixes labels Apr 16, 2020
@olbrich olbrich self-assigned this Apr 16, 2020
@coveralls
Copy link
Collaborator

coveralls commented Apr 16, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 695

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 95.8%
Files with Coverage Reduction New Missed Lines %
lib/devise-security/controllers/helpers.rb 1 64.15%
Totals Coverage Status
Change from base Build 670: -0.06%
Covered Lines: 1209
Relevant Lines: 1262
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Apr 16, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 694

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 95.8%
Files with Coverage Reduction New Missed Lines %
lib/devise-security/controllers/helpers.rb 1 64.15%
Totals Coverage Status
Change from base Build 670: -0.06%
Covered Lines: 1209
Relevant Lines: 1262
💛 - Coveralls

@olbrich
update readme and travis configs.
7d86ea2 
Co-authored-by: cholt2912
@olbrich olbrich added this to the 0.15.0 milestone Apr 16, 2020
@olbrich olbrich marked this pull request as ready for review April 16, 2020 01:40
@olbrich olbrich requested review from natebird and dillonwelch and removed request for natebird April 18, 2020 17:52
@olbrich olbrich merged commit 4b6e9a7 into devise-security:master Apr 23, 2020
@olbrich olbrich deleted the drop-ruby-2.4 branch April 23, 2020 00:28
dillonwelch added a commit that referenced this pull request Dec 31, 2020
@dillonwelch
Update devise-security.gemspec
15a12a7 
Ensure required ruby version matches what we officially support. Follow up to #189.
@dillonwelch dillonwelch mentioned this pull request Dec 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebird natebird natebird approved these changes

@dillonwelch dillonwelch Awaiting requested review from dillonwelch

Assignees

@olbrich olbrich

Labels
⬆️ dependencies Pull requests that update a dependency file 🏗️ maintenance #️⃣.#️⃣.#️⃣ Patch backwards-compatible bug fixes
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@olbrich @coveralls @natebird