-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating tutorial files #845
Conversation
new client instance. Then connect to the database passing an object with the | ||
connection details: | ||
|
||
```ts class="main.js" | ||
import { Client } from "https://deno.land/x/postgres/mod.ts"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the correct module? It's later referenced in the postgresjs
section as well. Or maybe that section is wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I understand the question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a section Connect to Postgres with deno-postgres
that references this module. Later we have a section Connect to Postgres with postgresjs
which references the same module. I'm mainly wondering if they're supposed to refer to different modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they're two different modules tho
https://deno.land/x/postgres
https://deno.land/x/postgresjs
--- | ||
title: "Read and Write Files" | ||
oldUrl: | ||
- /runtime/manual/examples/read_write_files/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we need a way to preserve those old redirects and link to the example page or something. Maybe we could add a new .json
file alongside go.json
and import that in our redirect code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we definitely need that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have added a new redirects file called 'oldurls' let me know if there could be a better name for this.
Co-authored-by: Marvin Hagemeister <[email protected]>
…nto tutorial-updates
No description provided.