Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating tutorial files #845

Merged
merged 17 commits into from
Sep 17, 2024
Merged

updating tutorial files #845

merged 17 commits into from
Sep 17, 2024

Conversation

thisisjofrank
Copy link
Collaborator

No description provided.

runtime/tutorials/connecting_to_databases.md Outdated Show resolved Hide resolved
new client instance. Then connect to the database passing an object with the
connection details:

```ts class="main.js"
import { Client } from "https://deno.land/x/postgres/mod.ts";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the correct module? It's later referenced in the postgresjs section as well. Or maybe that section is wrong.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand the question.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a section Connect to Postgres with deno-postgres that references this module. Later we have a section Connect to Postgres with postgresjs which references the same module. I'm mainly wondering if they're supposed to refer to different modules.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

---
title: "Read and Write Files"
oldUrl:
- /runtime/manual/examples/read_write_files/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we need a way to preserve those old redirects and link to the example page or something. Maybe we could add a new .json file alongside go.json and import that in our redirect code.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we definitely need that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have added a new redirects file called 'oldurls' let me know if there could be a better name for this.

@deno-deploy deno-deploy bot had a problem deploying to Preview September 17, 2024 11:07 Failure
oldurls.json Outdated Show resolved Hide resolved
@thisisjofrank thisisjofrank merged commit da64ba0 into main Sep 17, 2024
4 checks passed
@thisisjofrank thisisjofrank deleted the tutorial-updates branch September 17, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants