Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonize folder structure in text and code-snippet #1152

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

SirunGameDev
Copy link
Contributor

so https://github.com/denoland/tutorial-with-react/tree/main/api/util and code snippet actually works with instruction given in text.

  1. file is in repo in util - folder
  2. file is not in /api/api/ folder, like code snippets states.
  3. text says to create file in api-folder.

#1125 can be closed then. or merge both pr together, so that a good end result is reached.

so https://github.com/denoland/tutorial-with-react/tree/main/api/util 
and code snippet actually works with instruction given in text.
1. file is in repo in util - folder
2. file is not in /api/api/ folder, like code snippets states.
3. text says to create file in api-folder.
@SirunGameDev SirunGameDev mentioned this pull request Nov 17, 2024
@thisisjofrank
Copy link
Collaborator

Please run deno fmt on this branch before it can be merged.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit cd823ce into denoland:main Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants