Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add check to atomic op in kv example #1147

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Conversation

adit-bala
Copy link
Contributor

No description provided.

@adit-bala
Copy link
Contributor Author

Hey @thisisjofrank! Could I ask for some feedback on this pr :D

examples/kv.ts Outdated Show resolved Hide resolved
@adit-bala
Copy link
Contributor Author

@kt3k It should now work, I forgot actually to use the versionStamp. I don't know if this is the best place to show the functionality of an AtomicCheck, but I do think it is an important and powerful feature to display, do you think this has a place in this example, or should it be a separate one altogether?

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now! Thanks for updating!

@kt3k kt3k merged commit 5816eba into denoland:main Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants