Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lume + Tailwind changes #1077

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Update Lume + Tailwind changes #1077

merged 4 commits into from
Oct 28, 2024

Conversation

oscarotero
Copy link
Contributor

Hi, this PR contains two changes:

  • Upgrade Lume to the latest version (you were using a develop version from jsdelivr)
  • Changed Tailwind implementation: You had a custom plugin to use postcss with tailwind + autoprefixer plugins. Lume has already a postcss plugin with autoprefixer installed by default, so you don't need to create a custom plugin to use tailwind, just use the Lume's postcss plugin configured to use tailwind as an extra plugin.

Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks!

@marvinhagemeister
Copy link
Contributor

Looks like I don't have permissions to resolve the merge conflict. Once that's done it can land 👍

@thisisjofrank thisisjofrank merged commit 0097bd1 into denoland:main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants