chore: update dlint to v0.68.0 for internal

denoland · dsherret · Nov 4, 2024 · Nov 4, 2024 · Nov 4, 2024 · 572c2d95e33bba88011981ab5d76356f4cf8fa65
commit 572c2d95e33bba88011981ab5d76356f4cf8fa65
diff --git a/cli/bench/encode_into.js b/cli/bench/encode_into.js
@@ -1,6 +1,5 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
-
-// deno-lint-ignore-file no-console
+// deno-lint-ignore-file no-console no-process-globals
 
 let [total, count] = typeof Deno !== "undefined"
   ? Deno.args

diff --git a/cli/bench/getrandom.js b/cli/bench/getrandom.js
@@ -1,6 +1,5 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
-
-// deno-lint-ignore-file no-console
+// deno-lint-ignore-file no-console no-process-globals
 
 let [total, count] = typeof Deno !== "undefined"
   ? Deno.args

diff --git a/cli/bench/op_now.js b/cli/bench/op_now.js
@@ -1,6 +1,5 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
-
-// deno-lint-ignore-file no-console
+// deno-lint-ignore-file no-console no-process-globals
 
 const queueMicrotask = globalThis.queueMicrotask || process.nextTick;
 let [total, count] = typeof Deno !== "undefined"

diff --git a/cli/bench/secure_curves.js b/cli/bench/secure_curves.js
@@ -1,6 +1,5 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
-
-// deno-lint-ignore-file no-console
+// deno-lint-ignore-file no-console no-process-globals
 
 let [total, count] = typeof Deno !== "undefined"
   ? Deno.args

diff --git a/cli/bench/tty.js b/cli/bench/tty.js
@@ -1,6 +1,5 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
-
-// deno-lint-ignore-file no-console
+// deno-lint-ignore-file no-console no-process-globals
 
 const queueMicrotask = globalThis.queueMicrotask || process.nextTick;
 let [total, count] = typeof Deno !== "undefined"

diff --git a/cli/bench/url_parse.js b/cli/bench/url_parse.js
@@ -1,6 +1,5 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
-
-// deno-lint-ignore-file no-console
+// deno-lint-ignore-file no-console no-process-globals
 
 const queueMicrotask = globalThis.queueMicrotask || process.nextTick;
 let [total, count] = typeof Deno !== "undefined"

diff --git a/cli/bench/write_file.js b/cli/bench/write_file.js
@@ -1,6 +1,5 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
-
-// deno-lint-ignore-file no-console
+// deno-lint-ignore-file no-console no-process-globals
 
 const queueMicrotask = globalThis.queueMicrotask || process.nextTick;
 let [total, count] = typeof Deno !== "undefined"

diff --git a/ext/node/polyfills/_fs/_fs_common.ts b/ext/node/polyfills/_fs/_fs_common.ts
@@ -20,6 +20,7 @@ import {
   notImplemented,
   TextEncodings,
 } from "ext:deno_node/_utils.ts";
+import { type Buffer } from "node:buffer";
 
 export type CallbackWithError = (err: ErrnoException | null) => void;
 

diff --git a/ext/node/polyfills/_fs/_fs_open.ts b/ext/node/polyfills/_fs/_fs_open.ts
@@ -147,8 +147,8 @@ export function open(
 
 export function openPromise(
   path: string | Buffer | URL,
-  flags?: openFlags = "r",
-  mode? = 0o666,
+  flags: openFlags = "r",
+  mode = 0o666,
 ): Promise<FileHandle> {
   return new Promise((resolve, reject) => {
     open(path, flags, mode, (err, fd) => {

diff --git a/ext/node/polyfills/_fs/_fs_readv.ts b/ext/node/polyfills/_fs/_fs_readv.ts
@@ -15,6 +15,7 @@ import { maybeCallback } from "ext:deno_node/_fs/_fs_common.ts";
 import { validateInteger } from "ext:deno_node/internal/validators.mjs";
 import * as io from "ext:deno_io/12_io.js";
 import { op_fs_seek_async, op_fs_seek_sync } from "ext:core/ops";
+import process from "node:process";
 
 type Callback = (
   err: ErrnoException | null,

diff --git a/ext/node/polyfills/internal/crypto/keygen.ts b/ext/node/polyfills/internal/crypto/keygen.ts
@@ -29,6 +29,7 @@ import {
 } from "ext:deno_node/internal/validators.mjs";
 import { Buffer } from "node:buffer";
 import { KeyFormat, KeyType } from "ext:deno_node/internal/crypto/types.ts";
+import process from "node:process";
 
 import {
   op_node_generate_dh_group_key,

diff --git a/ext/node/polyfills/internal/crypto/random.ts b/ext/node/polyfills/internal/crypto/random.ts
@@ -38,6 +38,7 @@ import {
   ERR_INVALID_ARG_TYPE,
   ERR_OUT_OF_RANGE,
 } from "ext:deno_node/internal/errors.ts";
+import { Buffer } from "node:buffer";
 
 export { default as randomBytes } from "ext:deno_node/internal/crypto/_randomBytes.ts";
 export {

diff --git a/ext/node/polyfills/internal_binding/http_parser.ts b/ext/node/polyfills/internal_binding/http_parser.ts
@@ -126,6 +126,7 @@ ObjectSetPrototypeOf(HTTPParser.prototype, AsyncWrap.prototype);
 function defineProps(obj: object, props: Record<string, unknown>) {
   for (const entry of new SafeArrayIterator(ObjectEntries(props))) {
     ObjectDefineProperty(obj, entry[0], {
+      __proto__: null,
       value: entry[1],
       enumerable: true,
       writable: true,

diff --git a/ext/node/polyfills/vm.js b/ext/node/polyfills/vm.js
@@ -182,6 +182,7 @@ function getContextOptions(options) {
 
 let defaultContextNameIndex = 1;
 export function createContext(
+  // deno-lint-ignore prefer-primordials
   contextObject = {},
   options = { __proto__: null },
 ) {

diff --git a/runtime/js/99_main.js b/runtime/js/99_main.js
@@ -696,6 +696,7 @@ function bootstrapMainRuntime(runtimeOptions, warmup = false) {
     // are lost.
     let jupyterNs = undefined;
     ObjectDefineProperty(finalDenoNs, "jupyter", {
+      __proto__: null,
       get() {
         if (jupyterNs) {
           return jupyterNs;

diff --git a/tests/node_compat/test/fixtures/child-process-spawn-node.js b/tests/node_compat/test/fixtures/child-process-spawn-node.js
@@ -1,5 +1,6 @@
 const assert = require("assert");
 const debug = require('util').debuglog('test');
+const process = require("process");
 
 function onmessage(m) {
   debug("CHILD got message:", m);

diff --git a/tests/unit/globals_test.ts b/tests/unit/globals_test.ts
@@ -1,4 +1,5 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
+// deno-lint-ignore-file no-node-globals
 
 import {
   assert,

diff --git a/tools/lint.js b/tools/lint.js
@@ -56,12 +56,13 @@ async function dlint() {
     ":!:cli/tsc/compiler.d.ts",
     ":!:runtime/examples/",
     ":!:target/",
+    ":!:tests/ffi/tests/test.js",
     ":!:tests/registry/**",
     ":!:tests/specs/**",
     ":!:tests/testdata/**",
     ":!:tests/unit_node/testdata/**",
-    ":!:tests/wpt/suite/**",
     ":!:tests/wpt/runner/**",
+    ":!:tests/wpt/suite/**",
   ]);
 
   if (!sourceFiles.length) {

diff --git a/tools/util.js b/tools/util.js
@@ -11,7 +11,7 @@ export { delay } from "@std/async/delay";
 
 // [toolName] --version output
 const versions = {
-  "dlint": "dlint 0.60.0",
+  "dlint": "dlint 0.68.0",
 };
 
 const compressed = new Set(["ld64.lld", "rcodesign"]);
@@ -178,7 +178,7 @@ export function getPrebuiltToolPath(toolName) {
   return join(PREBUILT_TOOL_DIR, toolName + executableSuffix);
 }
 
-const commitId = "b8aac22e0cd7c1c6557a56a813fe0c25486fafee";
+const commitId = "7a3a6fee951b3381c59aa4c907274957f324ce8c";
 const downloadUrl =
   `https://raw.githubusercontent.com/denoland/deno_third_party/${commitId}/prebuilt/${platformDirName}`;