chore: upgrade to rust 1.82 and LLVM 19 #26615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
changed the title
satyarohith
reviewed
Oct 29, 2024
satyarohith
reviewed
Oct 29, 2024
satyarohith
reviewed
Oct 29, 2024
satyarohith
reviewed
Oct 29, 2024
satyarohith
reviewed
Oct 30, 2024
| @@ -1,4 +1,3 @@ | |||
| console.log(typeof await navigator.gpu.requestAdapter() === "object"); // Throws without `--unstable-gpu` | |||
There was a problem hiding this comment.
does it still fail with jammy?
if yes, we can use noble
There was a problem hiding this comment.
yes because the runner is on ubuntu 24 (only the sysroot is on jammy)
There was a problem hiding this comment.
Can you open an issue for gpu.requestAdapter bug on ubuntu 24?
bartlomieju
approved these changes
Oct 31, 2024
bartlomieju
pushed a commit
that referenced
this pull request
Nov 5, 2024
Upgrade to rust 1.82 and LLVM 19 . Removes one webusb test because `requestAdapter` not working on new ubuntu 24 runners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to rust 1.82 and LLVM 19 . Removes one webusb test because
requestAdapternot working on new ubuntu 24 runners