Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(runtime/permissions): use concrete error types #26464

Merged
merged 17 commits into from
Nov 4, 2024
Merged

refactor(runtime/permissions): use concrete error types #26464

merged 17 commits into from
Nov 4, 2024

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Oct 22, 2024 •
edited
Loading

No description provided.

@crowlKats crowlKats marked this pull request as draft October 22, 2024 00:49
@crowlKats crowlKats changed the title Permissions error rework refactor(runtime/permissions): use concrete error types Oct 22, 2024
@crowlKats crowlKats mentioned this pull request Oct 22, 2024
Open
25 tasks
@crowlKats crowlKats marked this pull request as ready for review October 22, 2024 11:26
bartlomieju
bartlomieju reviewed Oct 26, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, I'd like to get second pair of eyes on it before we land. @dsherret could you please take a look?

cli/args/flags.rs Outdated Show resolved Hide resolved
@crowlKats
Update cli/args/flags.rs
d89685b 
Signed-off-by: Leo Kettmeir <[email protected]>
dsherret
dsherret reviewed Oct 28, 2024
View reviewed changes
ext/websocket/lib.rs
)
.map_err(WebsocketError::Permission)?;
state.borrow_mut::<WP>().check_net_url(
&url::Url::parse(&url).map_err(WebsocketError::Url)?,
Copy link
Member

@dsherret dsherret Oct 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this shouldn't be parsing/allocating when we have full permissions (I'll look into this later)

dsherret
dsherret approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than PrompterError.

@crowlKats
address comment
643e7b1
@crowlKats
Merge branch 'main' into permissions-error-rework
0ccb774 
# Conflicts:
#	cli/npm/byonm.rs
#	runtime/permissions/lib.rs
@crowlKats
fix
2e6a910
@crowlKats crowlKats merged commit fe9f0ee into denoland:main Nov 4, 2024
17 checks passed
@crowlKats crowlKats deleted the permissions-error-rework branch November 4, 2024 17:17
bartlomieju pushed a commit that referenced this pull request Nov 5, 2024
@crowlKats @bartlomieju
refactor(runtime/permissions): use concrete error types (#26464)
1bdecc8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crowlKats @dsherret @bartlomieju