Skip to content

feat(upgrade): support LTS release channel #25123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 12, 2024
Merged

feat(upgrade): support LTS release channel #25123

merged 10 commits into from
Sep 12, 2024

Conversation

dsherret
Copy link
Member

No description provided.

bartlomieju
bartlomieju reviewed Aug 20, 2024
View reviewed changes
dsherret and others added 2 commits August 20, 2024 19:59
@dsherret @bartlomieju
Update cli/tools/upgrade.rs
479c508 
Co-authored-by: Bartek Iwańczuk <[email protected]>
Signed-off-by: David Sherret <[email protected]>
@dsherret
feedback
d889573
@dsherret dsherret marked this pull request as ready for review August 21, 2024 00:18
@bartlomieju bartlomieju modified the milestones: 2.0.0-rc.1, 2.0.0-rc.2 Aug 31, 2024
@bartlomieju bartlomieju modified the milestones: 2.0.0-rc.2, 2.0.0 Sep 10, 2024
bartlomieju
bartlomieju reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self, when no LTS is available the error message is bad:

Current Deno version: v2.0.0-rc.1
Looking up long term support version
error: Not found.

@bartlomieju bartlomieju mentioned this pull request Sep 12, 2024
Merged
bartlomieju added a commit that referenced this pull request Sep 12, 2024
@bartlomieju @dsherret
ci: Add action to cut LTS release (#25590)
e2875ae 
Factored from #25123.

---------

Signed-off-by: David Sherret <[email protected]>
Co-authored-by: David Sherret <[email protected]>
Co-authored-by: David Sherret <[email protected]>
bartlomieju
bartlomieju approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju merged commit c9c2531 into denoland:main Sep 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju