Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: disable fetching graph cache info except for deno info #17698

Merged
merged 1 commit into from
Feb 9, 2023
Merged

perf: disable fetching graph cache info except for deno info #17698

merged 1 commit into from
Feb 9, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 9, 2023 •
edited
Loading

I did a CPU profile for the first time on Deno's codebase and noticed it was spending about 5% of the time fetching cache information for deno graph. This is not necessary except for deno info.

With a basic example that imports oak and loads deno_std/node doing deno run:

Main: 272ms
This PR: 247ms

Profile from one of my other PRs that has a big deno graph refactor:

image

@dsherret dsherret requested a review from bartlomieju February 9, 2023 00:12
bartlomieju
bartlomieju approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch!

@dsherret dsherret merged commit 8b0a612 into denoland:main Feb 9, 2023
@dsherret dsherret deleted the perf_disable_fetching_cache_info branch February 9, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju