Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(npm): use per-thread package.json cache #17644

Merged
merged 1 commit into from
Feb 6, 2023
Merged

refactor(npm): use per-thread package.json cache #17644

merged 1 commit into from
Feb 6, 2023

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Feb 4, 2023 •
edited
Loading

This commit adds a per-thread cache for package.json files. It's similar to what Node.js
is doing.

@bartlomieju bartlomieju requested a review from dsherret February 4, 2023 23:36
dsherret
dsherret approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 34bfa2c into denoland:main Feb 6, 2023
@bartlomieju bartlomieju deleted the package_json_cache branch February 6, 2023 15:20
bartlomieju added a commit that referenced this pull request Feb 6, 2023
@bartlomieju
refactor(npm): use per-thread package.json cache (#17644)
9529138 
This commit adds a per-thread cache for `package.json` files. It's
similar to what Node.js is doing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @dsherret