Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade tokio to 1.24.2 #17467

Merged
merged 1 commit into from
Jan 19, 2023
Merged

chore: upgrade tokio to 1.24.2 #17467

merged 1 commit into from
Jan 19, 2023

Conversation

jasl
Copy link
Contributor

@jasl jasl commented Jan 18, 2023 •
edited
Loading

Tokio 1.24.2 fixed an unsoundness issue tokio-rs/tokio#5375 so I guess it is worthy to upgrade

@jasl jasl changed the title chore: upgrade tokio to 1.24.0 and tokio-tungstenite to 0.18.0 chore: upgrade tokio to 1.24.2 and tokio-tungstenite to 0.18.0 Jan 18, 2023
@jasl
Copy link
Contributor Author

jasl commented Jan 18, 2023

I was planning upgrade tokio-tungstenite as well that would help reduce 2 dependencies, but it add support for WS raw frame that break deno linting CI, so I'll try to separate to another PR

@jasl jasl changed the title chore: upgrade tokio to 1.24.2 and tokio-tungstenite to 0.18.0 chore: upgrade tokio to 1.24.2 Jan 18, 2023
littledivy
littledivy approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@littledivy littledivy merged commit c230a95 into denoland:main Jan 19, 2023
@jasl jasl deleted the upgrade-tokio branch January 19, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasl @littledivy