feat(ops): fast calls for Wasm #16776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
reviewed
Nov 23, 2022
aapoalas
reviewed
Nov 23, 2022
aapoalas
reviewed
Nov 23, 2022
| let ptr = backing_store.data().unwrap().as_ptr() as *mut u8; | ||
| let len = backing_store.byte_length(); | ||
| // SAFETY: `ptr` is a valid pointer to `len` bytes. | ||
| unsafe { std::slice::from_raw_parts_mut(ptr, len) } |
There was a problem hiding this comment.
Is it possible that ptr is a null pointer? eg. Wasm module created with 0 length memory buffer?
There was a problem hiding this comment.
@littledivy what's the answer here?
There was a problem hiding this comment.
Quick test shows that it is not nullptr for an empty memory buffer.
There was a problem hiding this comment.
Maybe it can be...idk...this is just an example
littledivy
changed the title
littledivy
changed the title
bartlomieju
approved these changes
Nov 27, 2022
kt3k
pushed a commit
that referenced
this pull request
Dec 1, 2022
This PR introduces Wasm ops. These calls are optimized for entry from
Wasm land.
The `#[op(wasm)]` attribute is opt-in.
Last parameter `Option<&mut [u8]>` is the memory slice of the Wasm
module *when entered from a Fast API call*. Otherwise, the user is
expected to implement logic to obtain the memory if `None`
```rust
#[op(wasm)]
pub fn op_args_get(
offset: i32,
buffer_offset: i32,
memory: Option<&mut [u8]>,
) {
// ...
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Wasm ops. These calls are optimized for entry from Wasm land.
The
#[op(wasm)]attribute is opt-in.Last parameter
Option<&mut [u8]>is the memory slice of the Wasm module when entered from a Fast API call. Otherwise, the user is expected to implement logic to obtain the memory ifNone