perf: more efficient deno cache and npm package info usage
#16592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Nov 11, 2022
| unresolved_tasks.push(tokio::task::spawn(async move { | ||
| let info = match maybe_info { | ||
| Some(info) => info?, | ||
| None => api.package_info(&package_req.name).await?, |
There was a problem hiding this comment.
This was previously had a high chance of making multiple requests for the same package when there were multiple different specifiers for the same package.
dsherret
commented
Nov 11, 2022
| @@ -1,5 +1,4 @@ | |||
| Download http://localhost:4545/npm/registry/chalk | |||
| Download http://localhost:4545/npm/registry/chalk/chalk-5.0.1.tgz | |||
There was a problem hiding this comment.
No longer downloads this twice...
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Nov 12, 2022
…d#16592) 1. There was a lot of cloning going on with `NpmPackageInfo`. This is now stored in an `Arc<NpmPackageInfo>` and cloning only happens on the individual version. 2. The package cache is now cleared from memory after resolution. 3. This surfaced a bug in `deno cache` and I noticed it can be more efficient if we have multiple root specifiers if we provide all the specifiers as roots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NpmPackageInfo. This is now stored in anArc<NpmPackageInfo>and cloning only happens on the individual version.deno cacheand I noticed it can be more efficient if we have multiple root specifiers if we provide all the specifiers as roots.