Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): add ServerCapabilities::encoding #16444

Merged
merged 1 commit into from
Oct 27, 2022
Merged

fix(lsp): add ServerCapabilities::encoding #16444

merged 1 commit into from
Oct 27, 2022

Conversation

bartlomieju
Copy link
Member

This caused v1.27.0 publishing to fail.

@bartlomieju bartlomieju requested a review from dsherret October 27, 2022 15:49
dsherret
dsherret approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Cargo lockfile seems somewhat useless for publishing, but I guess it makes sense.

@bartlomieju bartlomieju merged commit c27942f into denoland:main Oct 27, 2022
@bartlomieju bartlomieju deleted the fix_publish branch October 27, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @dsherret