Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(core): do not drive JsInspector by default #16410

Merged
merged 4 commits into from
Oct 26, 2022
Merged

perf(core): do not drive JsInspector by default #16410

merged 4 commits into from
Oct 26, 2022

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Oct 25, 2022 •
edited
Loading

Part of #16377

bartlomieju
bartlomieju reviewed Oct 25, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does REPL still work as expected?

@littledivy
Copy link
Member Author

yup

deno/runtime/worker.rs

Line 445 in fb36d9c

self.js_runtime.maybe_init_inspector();

@littledivy littledivy merged commit 851db03 into denoland:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littledivy @bartlomieju