fix(core) Include causes when converting anyhow errors to JS exceptions #16397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks @honzasp, any chance you could add some test case so we don't accidently regress in the future? |
|
I added a test to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an op returns an
anyhowerror with a cause (usually added using the.context()method), theErrorthrown into JavaScript contains only the message of the outernmost error in the chain.This PR simply changes the formatting of
anyhow::Errorfrom"{}"to"{:#}":https://docs.rs/anyhow/latest/anyhow/struct.Error.html#display-representations
This significantly improves errors for code that embeds Deno and defines custom ops. For example, in chiselstrike/chiselstrike, this PR improves an error message like
to