Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to TypeScript 4.7.4 #15022

Merged
merged 1 commit into from
Jul 4, 2022
Merged

feat: update to TypeScript 4.7.4 #15022

merged 1 commit into from
Jul 4, 2022

Conversation

espindola
Copy link
Contributor

Also update the update_typescript.md document to match the current
status.

Also update the update_typescript.md document to match the current
status.
@bartlomieju
Copy link
Member

What's the reason for this update? We usually don't upgrade TypeScript in-between minor versions.

@espindola
Copy link
Contributor Author

What's the reason for this update? We usually don't upgrade TypeScript in-between minor versions.

I hit an issue trying https://github.com/deepkit/deepkit-framework/tree/master/packages/type-compiler, which is based on 4.7.4. I decided to first update deno to the same version to check if was an incompatibility with 4.7.2. It wasn't (the issue is deepkit/deepkit-framework#283), but since I had the upgrade I decided to offer it.

Would you be interested in the update to tools/update_typescript.md?

@bartlomieju
Copy link
Member

I see, makes sense. I think we can land it then.

Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants