fix(compile): Support import maps #13756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
force-pushed
the
compile_import_maps
branch
2 times, most recently
from
0d27b55 to
858dd9f
Compare
littledivy
force-pushed
the
compile_import_maps
branch
from
858dd9f to
ddd18c4
Compare
dsherret
pushed a commit
to dsherret/deno
that referenced
this pull request
Feb 24, 2022
dsherret
pushed a commit
that referenced
this pull request
Feb 24, 2022
| @@ -423,6 +425,8 @@ async fn compile_command( | |||
| generic_error("There should only be one reference to ModuleGraph") | |||
| })?; | |||
|
|
|||
| graph.valid().unwrap(); | |||
There was a problem hiding this comment.
This should not be a panic…
There was a problem hiding this comment.
Yikes, good catch, you are right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13748