Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): disable config discovery for remote script #13745

Merged
merged 3 commits into from
Feb 25, 2022
Merged

fix(cli): disable config discovery for remote script #13745

merged 3 commits into from
Feb 25, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Feb 23, 2022

This implements the idea proposed in #13744.

This PR disables the config auto-discovery when executing remote scripts (deno run <remote_script>)

closes #13744

@kt3k kt3k requested a review from bartlomieju as a code owner February 23, 2022 06:10
@kt3k kt3k requested review from ry and bartlomieju and removed request for bartlomieju February 23, 2022 06:10
ry
ry reviewed Feb 23, 2022
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test showing that with a remote script, the config file isn't auto-detected?

@kt3k
Copy link
Member Author

kt3k commented Feb 24, 2022

Could you add a test showing that with a remote script, the config file isn't auto-detected?

Added integration test cases

bartlomieju
bartlomieju approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ry
ry approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kt3k kt3k merged commit 111c343 into denoland:main Feb 25, 2022
@kt3k kt3k deleted the fix/disable-config-discovery-for-remote-script branch February 25, 2022 05:39
satyarohith pushed a commit that referenced this pull request Mar 3, 2022
@kt3k @satyarohith
fix(cli): disable config discovery for remote script (#13745)
556e05c
satyarohith pushed a commit that referenced this pull request Mar 3, 2022
@kt3k @satyarohith
fix(cli): disable config discovery for remote script (#13745)
1a0c85d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: disable auto-discovery of config file for deno run <remote entrypoint>
3 participants
@kt3k @ry @bartlomieju