chore: use rustfmt cli via dprint for faster format #13735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Feb 21, 2022
| @@ -9,8 +9,12 @@ | |||
| "json": { | |||
| "deno": true | |||
| }, | |||
| "exec": { | |||
| "associations": "**/*.rs", | |||
| "rustfmt": "rustfmt" | |||
There was a problem hiding this comment.
The exec plugin has no knowledge of rustfmt until being provided it here. This makes it call the rustfmt cli and format over stdin.
|
A nice side effect is that now rust files get automatically formatted on save if using dprint's vscode extension. |
dsherret
added a commit
to dsherret/deno
that referenced
this pull request
Feb 24, 2022
dsherret
added a commit
that referenced
this pull request
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses dprint to orchestrate formatting via rustfmt.
Before: 6384ms
After: 932ms (3677ms on the first format or with incremental disabled)
I think part of the previous ~2.5 slowdown was from collecting the file paths. Dprint's CLI has a super fast custom glob walking solution.