Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): support data url #13667

Merged
merged 2 commits into from
Feb 25, 2022
Merged

feat(compiler): support data url #13667

merged 2 commits into from
Feb 25, 2022

Conversation

lowlighter
Copy link
Contributor

Noticed that deno bundle does seems to support data url:

PS> deno bundle "data:application/javascript;base64,Y29uc29sZS5sb2coImhlbGxvIHdvcmxkIik7"
Bundle data:application/javascript;base64,Y29uc29sZS5sb2coImhlbGxvIHdvcmxkIik7
// deno-fmt-ignore-file
// deno-lint-ignore-file
// This code was bundled using `deno bundle` and it's not recommended to edit it manually

console.log("hello world");

However when using it programmatically with Deno.emit, there is a checkRelative function which only support http(s)/file protocols, not the data one. It gets converted into a relative path instead of being passed as it.

Should close #11141

@CLAassistant
Copy link

CLAassistant commented Feb 14, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lowlighter lowlighter marked this pull request as ready for review February 14, 2022 08:06
@bartlomieju bartlomieju requested review from kitsonk and removed request for bartlomieju February 14, 2022 12:41
kitsonk
kitsonk approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Apologies for the delay

@kitsonk kitsonk merged commit c59152e into denoland:main Feb 25, 2022
@lowlighter
Copy link
Contributor Author

No worries!
Thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno.emit panicks when using data:application/typescript;base64 as url
3 participants
@lowlighter @CLAassistant @kitsonk