fix(check): expose more globals from @types/node (#26603)

Extracted out of #26558 Closes #26578
denoland · Oct 29, 2024 · 4823849 · 4823849
1 parent 96e931a
commit 4823849
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 11 deletions.
diff --git a/cli/tsc/99_main_compiler.js b/cli/tsc/99_main_compiler.js
@@ -1337,18 +1337,12 @@ delete Object.prototype.__proto__;
     "console",
     "Console",
     "ErrorConstructor",
-    "exports",
     "gc",
     "Global",
     "ImportMeta",
     "localStorage",
-    "module",
-    "NodeModule",
-    "NodeRequire",
-    "process",
     "queueMicrotask",
     "RequestInit",
-    "require",
     "ResponseInit",
     "sessionStorage",
     "setImmediate",

diff --git a/tests/specs/npm/compare_globals/__test__.jsonc b/tests/specs/npm/compare_globals/__test__.jsonc
@@ -1,4 +1,4 @@
 {
-  "args": "run --allow-read --check=all compare_globals/main.ts",
-  "output": "compare_globals/main.out"
+  "args": "run --allow-read --check=all main.ts",
+  "output": "main.out"
 }
diff --git a/.../compare_globals/compare_globals/main.out → tests/specs/npm/compare_globals/main.out b/.../compare_globals/compare_globals/main.out → tests/specs/npm/compare_globals/main.out
@@ -8,10 +8,11 @@ Download http://localhost:4260/@denotest/globals/1.0.0.tgz
 Download http://localhost:4260/@types/node/node-22.5.4.tgz
 Download http://localhost:4260/undici-types/undici-types-6.19.8.tgz
 [UNORDERED_END]
-Check file:///[WILDCARD]/compare_globals/main.ts
+Check file:///[WILDCARD]/main.ts
 true
 true
 []
+process equals process true
 setTimeout 1 false
 setTimeout 2 function
 setTimeout 3 function

diff --git a/...m/compare_globals/compare_globals/main.ts → tests/specs/npm/compare_globals/main.ts b/...m/compare_globals/compare_globals/main.ts → tests/specs/npm/compare_globals/main.ts
@@ -5,10 +5,17 @@ console.log(globals.global === globals.globalThis);
 // @ts-expect-error even though these are the same object, they have different types
 console.log(globals.globalThis === globalThis);
 console.log(globals.process.execArgv);
+console.log("process equals process", process === globals.process);
 
 type AssertTrue<T extends true> = never;
-type _TestNoProcessGlobal = AssertTrue<
-  typeof globalThis extends { process: any } ? false : true
+type _TestHasProcessGlobal = AssertTrue<
+  typeof globalThis extends { process: any } ? true : false
+>;
+type _TestProcessGlobalVersion = AssertTrue<
+  typeof process.versions.node extends string ? true : false
+>;
+type _TestNoBufferGlogal = AssertTrue<
+  typeof globalThis extends { Buffer: any } ? false : true
 >;
 type _TestHasNodeJsGlobal = NodeJS.Architecture;