fix(task): handle carriage return in task description (#27099)

Ref #27069 (comment)
denoland · Nov 27, 2024 · 4700f12 · 4700f12
1 parent e2f7e03
commit 4700f12
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/cli/tools/task.rs b/cli/tools/task.rs
@@ -721,7 +721,7 @@ fn print_available_tasks(
     )?;
     if let Some(description) = &desc.task.description {
       let slash_slash = colors::italic_gray("//");
-      for line in description.split('\n') {
+      for line in description.lines() {
         writeln!(writer, "    {slash_slash} {}", colors::italic_gray(line))?;
       }
     }

diff --git a/tests/specs/task/description/deno.json b/tests/specs/task/description/deno.json
@@ -7,6 +7,10 @@
     "multiline_description": {
       "description": "This is a multiline\ndescription",
       "command": "echo 2"
+    },
+    "multiline_description_carriage_return": {
+      "description": "This is a multiline\r\ndescription\r\n",
+      "command": "echo 3"
     }
   }
 }
diff --git a/tests/specs/task/description/main.out b/tests/specs/task/description/main.out
@@ -6,3 +6,7 @@ Available tasks:
     // This is a multiline
     // description
     echo 2
+- multiline_description_carriage_return
+    // This is a multiline
+    // description
+    echo 3