Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove csv in custom data #457

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Remove csv in custom data #457

wants to merge 1 commit into from

Conversation

rkspx
Copy link
Contributor

@rkspx rkspx commented Feb 2, 2023

  • remove erroneous implementation for splitting custom data value by comma

@rkspx rkspx requested a review from mmta as a code owner February 2, 2023 02:07
@rkspx rkspx marked this pull request as draft February 2, 2023 02:08
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 96.52% // Head: 96.51% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (d138f44) compared to base (5d83e2a).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
- Coverage   96.52%   96.51%   -0.01%     
==========================================
  Files          45       45              
  Lines        3219     3215       -4     
==========================================
- Hits         3107     3103       -4     
  Misses         84       84              
  Partials       28       28
Impacted Files Coverage Δ
internal/pkg/dsiem/rule/rule.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmta mmta Awaiting requested review from mmta mmta is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rkspx