Add unselected option to select widget when no default is set #673
Conversation
| return option; | ||
| }); | ||
| const options = [ | ||
| ...(field.get('default', false) ? [] : [{ label: '<not set>', value: '' }]), |
There was a problem hiding this comment.
I don't think the <not set> field should be a regular option -- I don't think it should be selectable. After an option has been selected, the <not set> field should be hidden.
There was a problem hiding this comment.
I would change { label: '<not set>', value: '' } to { label: '<not set>', disabled: true }.
There was a problem hiding this comment.
@tech4him1 good point, I'll make the change. It's always possible to allow an empty value by explicitly adding it to the options.
There was a problem hiding this comment.
@Benaiah actually, now that you say that I'm not sure it does. If I use this PR like it is right now, it won't let me save if I select <not set>.
There was a problem hiding this comment.
@tech4him1 "not sure it does" 👈 not sure it does what?
There was a problem hiding this comment.
@Benaiah There is no way, AFAIK, to save a select with an empty value unless required: false. Is that what you meant?
There was a problem hiding this comment.
@tech4him1 I meant that if you want to save an empty string, you can always add an option like { label: "Empty", value: "" } to the config. <not set> shouldn't be selectable, as you suggested.
Benaiah
force-pushed
the
fix-select-widget-unselected-state
branch
from
337d876
to
0de01e1
Compare
|
@tech4him1, @erquhart this is finished and r2r. |
erquhart
dismissed
tech4him1’s stale review
His review was LGTM with a caveat, caveat addressed.
- Summary
Add a "not selected" option to the select widget when there is no default set. Closes #562.
- Test plan
Tested manually.
- Description for the changelog
Add unselected option to select widget when no default is set.
- A picture of a cute animal (not mandatory but encouraged)