[docs] Update description of pg replica identity prop#6009
Merged
jpechane merged 4 commits intodebezium:mainfrom Nov 25, 2024
Merged
Conversation
…bles (cherry picked from commit 8ff21e4e245c231b1e4748cdc20cf9687592463d)
(cherry picked from commit 3484fd04cda473f1f52b34689ad3051b4aeddbd9)
(cherry picked from commit 9ffdc87fe71f6a30cc3e9f59751f716fe23c6e23)
vjuranek
reviewed
Nov 22, 2024
Member
vjuranek
left a comment
vjuranek
left a comment
There was a problem hiding this comment.
One thing to make the description more precise, otherwise LGTM.
| |Set this property to apply specific link:https://www.postgresql.org/docs/current/sql-altertable.html#SQL-ALTERTABLE-REPLICA-IDENTITY[replica identity] settings to a subset of the tables that a connector captures, based on the table name. | ||
| The replica identity values that the property sets overwrite the replica identity values that are set in the database. | ||
|
|
||
| This property applies changes to the replica identity of a table only if the connector is configured to capture the table, based on settings in the xref:postgresql-property-table-include-list[`table.include.list`] and xref:postgresql-property-table-exclude-list[`table.exclude.list`] properties. |
Member
There was a problem hiding this comment.
Captured tables can be detemined also by using schema.include.list and/or schema.exclude.list
Contributor
Author
There was a problem hiding this comment.
Captured tables can be detemined also by using schema.include.list and/or schema.exclude.list
Moved information about the property applying to captured tables to an admonition at the end of the description and modified the text to note the role of the schema.*.list properties in determining the tables to capture.
Contributor
|
@roldanbob Applied, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edits the description of the PostgreSQL
replica.identity.autoset.valuesproperty to specify that it applies changes only to captured tables.Also applies additional unrelated language and formatting changes to improve clarity and consistency with other documentation.
Supersedes the closed PR #6005 on which it is based