DBZ-8441 Make AbstractConnectorTest#createEngine method abstract#6004
Merged
jpechane merged 1 commit intodebezium:mainfrom Nov 25, 2024
Merged
DBZ-8441 Make AbstractConnectorTest#createEngine method abstract#6004jpechane merged 1 commit intodebezium:mainfrom
jpechane merged 1 commit intodebezium:mainfrom
Conversation
With this change, all `EmbeddedEngine` stuff which is used in the tests should be localted only in `EmbeddedEngineTest` and `TestingEmbeddedEngine` classes, i.e. used only for running tests for `EmbeddedEngine` itself.
Member
Author
|
Vitess failure is expected, test should start passing once debezium/debezium-connector-vitess#214 is merged (and would be nice to merge Vitess PR first). |
Contributor
|
@vjuranek Applied, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, all
EmbeddedEnginestuff which is used in the tests should be localted only inEmbeddedEngineTestandTestingEmbeddedEngineclasses, i.e. used only for running tests forEmbeddedEngineitself.https://issues.redhat.com/browse/DBZ-8441