DBZ-8302: Treat oracle negative timestamp values as -infinity.#5996
DBZ-8302: Treat oracle negative timestamp values as -infinity.#5996dongwook-chan wants to merge 3 commits intodebezium:mainfrom
Conversation
Co-authored-by: Bue-von-hon <[email protected]> Co-authored-by: chungeun-choi <[email protected]> Co-authored-by: sean-k1 <[email protected]>
jpechane
left a comment
jpechane
left a comment
There was a problem hiding this comment.
@dongwook-chan Thanks for the PR. Could you please reformat the code so the tests are executed. lso could you please add a test case for the new feature? Thanks
debezium-connector-jdbc/pom.xml
Outdated
| <dependency> | ||
| <groupId>com.oracle.database.jdbc</groupId> | ||
| <artifactId>ojdbc11</artifactId> | ||
| <version>23.6.0.24.10</version> |
There was a problem hiding this comment.
Why it is necessary to override the version here?
There was a problem hiding this comment.
Sorry, my bad! I removed the version tag.
There was a problem hiding this comment.
@jpechane
I also added config variable ORACLE_INFINITY_CONVERTER_ENABLE for the feature,
but have trouble accessing it from convertInfinityTimestampValue(). Could you give some advice on this? And I would like some advice on running integration test too.
There was a problem hiding this comment.
I think this would require a different approach. The class io.debezium.connector.jdbc.dialect.oracle.ZonedTimestampType should provide two instances. The existing one and one with the requested behaviour. io.debezium.connector.jdbc.dialect.oracle.OracleDatabaseDialect.registerTypes() wil then register the one based on connector config.
Naros
left a comment
Naros
left a comment
There was a problem hiding this comment.
Hi @dongwook-chan do you intend to add test cases?
|
❌ Developer Certificate of Origin (DCO) check failed. Hi @dongwook-chan, please sign off all commits with: If pull request commits are not signed off, the pull request cannot be merged. For more information about why this is required, please see our blog about contribution requirement changes. |
3 participants
We were hoping to create a PR on this issue but found that the repo is archived.
Below is the PR that we attempted to create.
We want to refer to config from ZonedTimestampType.
But it takes a lot of depth to reach config from this class.
So we would you to provide some advice on this issue pls.
https://github.com/dongwook-chan/debezium-connector-jdbc/blob/2e2aa669c2a4f50ba85196d5cf8f4115a5155c28/src/main/java/io/debezium/connector/jdbc/dialect/mysql/ZonedTimestampType.java#L37-L39
We tried to run integration test on jdbc sink connector but failed.
So if you have any instructions on this please provide.