DBZ-8336 Error Handling Mode for ReselectColumnsPostProcessor#5944
Merged
Naros merged 2 commits intodebezium:mainfrom Jan 22, 2025
Merged
DBZ-8336 Error Handling Mode for ReselectColumnsPostProcessor#5944Naros merged 2 commits intodebezium:mainfrom
Naros merged 2 commits intodebezium:mainfrom
Conversation
gaurav7261
force-pushed
the
DBZ-8336
branch
2 times, most recently
from
56dd0e1 to
0f08259
Compare
Contributor
Author
|
@Naros can you please review |
Naros
requested changes
Oct 29, 2024
Member
Naros
left a comment
Naros
left a comment
There was a problem hiding this comment.
Thanks @gaurav7261, a few inline suggestions, please.
documentation/modules/ROOT/pages/post-processors/reselect-columns.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/ROOT/pages/post-processors/reselect-columns.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/ROOT/pages/post-processors/reselect-columns.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/ROOT/pages/post-processors/reselect-columns.adoc
Outdated
Show resolved
Hide resolved
debezium-core/src/main/java/io/debezium/processors/reselect/ReselectColumnsPostProcessor.java
Outdated
Show resolved
Hide resolved
debezium-core/src/main/java/io/debezium/processors/reselect/ReselectColumnsPostProcessor.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Hi @Naros, all review changes are done, thanks for reviewing |
gaurav7261
changed the title
Contributor
Author
|
@Naros can you please review this |
1 similar comment
Contributor
Author
|
@Naros can you please review this |
Naros
approved these changes
Jan 21, 2025
Member
Naros
left a comment
Naros
left a comment
There was a problem hiding this comment.
Overall LGTM, I've rebased against main to check CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DBZ-8336