Skip to content

Dbz 8281 Provide outbox Quarkus devservice#5903

Draft
dcdh wants to merge 9 commits intodebezium:mainfrom
dcdh:DBZ-8281
Draft

Dbz 8281 Provide outbox Quarkus devservice#5903
dcdh wants to merge 9 commits intodebezium:mainfrom
dcdh:DBZ-8281

Conversation

@dcdh
Copy link

@dcdh dcdh commented Sep 29, 2024

No description provided.

@github-actions
Copy link

Welcome as a new contributor to Debezium, @dcdh. Reviewers, please add missing author name(s) and alias name(s) to the COPYRIGHT.txt and Aliases.txt respectively.

@@ -0,0 +1,135 @@
/*
Copy link
Author

@dcdh dcdh Sep 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hack, will remove it when changed will be pushed and released inside Quarkus
Keep this PR in draft until done

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@Naros Naros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few inline comments @dcdh, if you could take a look.
If you could also rebase the PR, we'd appreciate it.

@github-actions
Copy link

github-actions bot commented Oct 5, 2024

Hi @dcdh, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

3 similar comments
@github-actions
Copy link

github-actions bot commented Oct 5, 2024

Hi @dcdh, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@github-actions
Copy link

github-actions bot commented Oct 5, 2024

Hi @dcdh, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@github-actions
Copy link

github-actions bot commented Oct 5, 2024

Hi @dcdh, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@dcdh
Copy link
Author

dcdh commented Oct 5, 2024

@Naros

Thanks for reviewing this PR. I have resolved all of your comments.

Inside DebeziumConnectorStatus I have removed state() method because it is not used.

I forget to do little commits for the review instead I rewrite them. I am sorry...

Documentation has been generated using chatgpt, lot easier way.

Moreover, I have extracted the postgresql part regarding database configuration to implement other database kind likes mysql, mssql, oracle. I did not see any sample about them on how to setup a connector for debezium outbox. Do you have some of them ?
For each of them I would want to develop integration testing too.
5 targets jdbc database (db2, oracle, postgresql, myssql, mysql) * 2 architectures (blocking, reactive). Quite a lot

Regards,
Damien

@dcdh dcdh force-pushed the DBZ-8281 branch 2 times, most recently from 3949168 to d1f3ad3 Compare October 5, 2024 17:46
dcdh added 2 commits October 6, 2024 00:04
…e class

- Moved JdbcDataSourceSourceConnector into its own class to improve modularity and reusability.
- This extraction helps isolate database connector logic and simplifies future extensions.
…vely for logging messages. This ensures uniqueness and helps maintain clear and organized logging.
@Naros
Copy link
Member

Naros commented Jan 6, 2026

❌ Developer Certificate of Origin (DCO) check failed.

Hi @dcdh, please sign off all commits with:

git commit -s

If pull request commits are not signed off, the pull request cannot be merged. For more information about why this is required, please see our blog about contribution requirement changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants