DBZ-8207 Use whole composite key in incremental snapshot notifications #5831

vjuranek · 2024-09-05T09:04:35Z

jpechane · 2024-09-05T11:40:31Z

@vjuranek Test failures are related

jpechane · 2024-09-06T05:35:59Z

@vjuranek Test failures are related - timeout in new test

vjuranek · 2024-09-07T20:26:06Z

Test failures still related.

vjuranek · 2025-04-29T07:26:27Z

Test failure is unrelated, filed DBZ-8985 for it

jpechane

@vjuranek LGTM, thanks.
I left one comment related to using a bit more functional code style. When addressed feel free to merge the PR yourself.

.../src/main/java/io/debezium/pipeline/notification/IncrementalSnapshotNotificationService.java

vjuranek force-pushed the DBZ-8207 branch from 515a0f1 to 6a4b402 Compare September 5, 2024 14:12

vjuranek force-pushed the DBZ-8207 branch from 6a4b402 to 88e5b8a Compare September 6, 2024 13:55

vjuranek marked this pull request as draft September 7, 2024 20:26

vjuranek force-pushed the DBZ-8207 branch 4 times, most recently from 310bae1 to 9be1dae Compare April 28, 2025 13:34

vjuranek marked this pull request as ready for review April 29, 2025 07:26

jpechane reviewed Apr 30, 2025

View reviewed changes

.../src/main/java/io/debezium/pipeline/notification/IncrementalSnapshotNotificationService.java Outdated Show resolved Hide resolved

vjuranek force-pushed the DBZ-8207 branch from 9be1dae to 14159ac Compare April 30, 2025 08:48

vjuranek added 3 commits May 5, 2025 11:15

DBZ-8207 Use whole composite key in incremental snapshot notifications

6d9b57c

DBZ-8207 Wait for streaming to start in the test

4d98f6e

DBZ-8207 Use functional syntax

41328ee

vjuranek force-pushed the DBZ-8207 branch from 14159ac to 41328ee Compare May 5, 2025 09:15

vjuranek merged commit a99af17 into debezium:main May 5, 2025
39 checks passed

Provide feedback