DBZ-8003 Postgres Connector throw exception from keepAliveExecutor#5802
DBZ-8003 Postgres Connector throw exception from keepAliveExecutor#5802loserwang1024 wants to merge 1 commit intodebezium:mainfrom
Conversation
|
Welcome as a new contributor to Debezium, @loserwang1024. Reviewers, please add missing author name(s) and alias name(s) to the COPYRIGHT.txt and Aliases.txt respectively. |
| LOGGER.error( | ||
| "received unexpected exception will perform keep alive", | ||
| exp); | ||
| keepAliveException = exp; | ||
| } | ||
|
|
||
| try { | ||
| metronome.pause(); | ||
| } | ||
| catch (InterruptedException e) { | ||
| LOGGER.warn( | ||
| "Keep alive thread has already be shutdown."); |
There was a problem hiding this comment.
This formatting for LOGGER does not really conform to the remainder of the code base.
Would you please align those to be on a single line each, thanks!.
|
❌ Developer Certificate of Origin (DCO) check failed. Hi @loserwang1024, please sign off all commits with: If pull request commits are not signed off, the pull request cannot be merged. For more information about why this is required, please see our blog about contribution requirement changes. |
loserwang1024
force-pushed
the
DBZ-8003
branch
from
6dc25ab to
1bae57a
Compare
|
❌ Developer Certificate of Origin (DCO) check failed. Hi @loserwang1024, please sign off all commits with: If pull request commits are not signed off, the pull request cannot be merged. For more information about why this is required, please see our blog about contribution requirement changes. |
| final PGReplicationStream stream = s; | ||
|
|
||
| return new ReplicationStream() { | ||
| return new ReplicationStream() {keepAliveRunning |
There was a problem hiding this comment.
IMHO this is syntax error
|
|
||
| private void checkKeepAliveException() { | ||
| if (keepAliveException != null) { | ||
| throw new RuntimeException("received unexpected exception will perform keep alive", keepAliveException); |
There was a problem hiding this comment.
| throw new RuntimeException("received unexpected exception will perform keep alive", keepAliveException); | |
| throw new DebeziumException("Received unexpected exception will perform keep alive", keepAliveException); |
3 participants
As discribe in https://issues.redhat.com/browse/DBZ-8003 , postgres Connector throw exception from keepAliveExecutor