Skip to content
/ debezium Public

DBZ-7356 Remove skipping Avro validation#5755

Merged
jpechane merged 1 commit intodebezium:mainfrom
vjuranek:DBZ-7356
Apr 30, 2025
Merged

DBZ-7356 Remove skipping Avro validation#5755
jpechane merged 1 commit intodebezium:mainfrom
vjuranek:DBZ-7356

Conversation

@vjuranek
Copy link
Member

@vjuranek vjuranek commented Aug 9, 2024

@jpechane
Copy link
Contributor

jpechane commented Aug 9, 2024

/packit test --labels oracle

@vjuranek vjuranek marked this pull request as draft August 12, 2024 06:38
@vjuranek
Copy link
Member Author

vjuranek commented Aug 16, 2024

/packit test --labels oracle

@vjuranek
Copy link
Member Author

vjuranek commented Aug 27, 2024

The test failures are not related to the change, fails seems to be random and fails mostly with

17:04:45,701 [ERROR]   IncrementalSnapshotCaseSensitiveIT>AbstractIncrementalSnapshotTest.stopCurrentIncrementalSnapshotWithoutCollectionsAndTakeNewNewIncrementalSnapshotAfterRestart:604->AbstractIncrementalSnapshotTest.sendAdHocSnapshotSignalAndWait:1201 » ConditionTimeout Condition io.debezium.pipeline.source.snapshot.incremental.AbstractIncrementalSnapshotTest$$Lambda/0x00007f500cfdb148 was not fulfilled within 1 minutes.

sometimes with

12:16:18,369 [ERROR]   EmbeddedInfinispanProcessorIT>AbstractProcessorTest.shouldLogAdditionalDetailsForAbandonedTransaction:236 expected:<[tru]e> but was:<[fals]e>
12:16:18,369 [ERROR]   MemoryProcessorIT>AbstractProcessorTest.shouldLogAdditionalDetailsForAbandonedTransaction:236 expected:<[tru]e> but was:<[fals]e>

@vjuranek vjuranek marked this pull request as ready for review August 27, 2024 07:52
@Naros
Copy link
Member

Naros commented Aug 29, 2024

The test failures are not related to the change, fails seems to be random and fails mostly with

Hi @vjuranek can you create a Jira for these if one doesn't already exist and ping on it so I can take a look. These tests particularly with the processors seem very dubious and unexpected.

@vjuranek
Copy link
Member Author

vjuranek commented Aug 29, 2024

@Naros FIY, I filed DBZ-8190 and DBZ-8191. I'll try to investigate myself, but very likely will ask you for help :-) (already have some issues with 19.3.0-xs image)

@vjuranek vjuranek force-pushed the DBZ-7356 branch 2 times, most recently from 8606529 to b9e6332 Compare April 24, 2025 09:24
@vjuranek
Copy link
Member Author

vjuranek commented Apr 24, 2025

/packit test --labels oracle

1 similar comment
@vjuranek
Copy link
Member Author

vjuranek commented Apr 24, 2025

/packit test --labels oracle

@vjuranek
Copy link
Member Author

vjuranek commented Apr 28, 2025

/packit test --labels oracle

@vjuranek
Copy link
Member Author

vjuranek commented Apr 29, 2025

Test failures are unrelated:

22:30:40,189 [ERROR]   IncrementalSnapshotCaseSensitiveIT>AbstractIncrementalSnapshotTest.stopCurrentIncrementalSnapshotWithoutCollectionsAndTakeNewNewIncrementalSnapshotAfterRestart:610->AbstractIncrementalSnapshotTest.sendAdHocSnapshotSignalAndWait:1248 » ConditionTimeout Condition io.debezium.pipeline.source.snapshot.incremental.AbstractIncrementalSnapshotTest$$Lambda/0x00007f094d0ac250 was not fulfilled within 1 minutes.

and

01:03:53,314 [ERROR]   IncrementalSnapshotCaseSensitiveIT>AbstractIncrementalSnapshotTest.stopCurrentIncrementalSnapshotWithoutCollectionsAndTakeNewNewIncrementalSnapshotAfterRestart:610->AbstractIncrementalSnapshotTest.sendAdHocSnapshotSignalAndWait:1248 » ConditionTimeout Condition io.debezium.pipeline.source.snapshot.incremental.AbstractIncrementalSnapshotTest$$Lambda/0x00007fc3210b4470 was not fulfilled within 1 minutes.
01:03:53,314 [ERROR]   OracleSchemaMigrationIT.shouldParseSchemaChangeWithoutErrorOnFilteredTableWithRawDataType:1151 » ConditionTimeout Condition io.debezium.connector.oracle.OracleSchemaMigrationIT$$Lambda/0x00007fc320a44440 was not fulfilled within 2 minutes.

@vjuranek
Copy link
Member Author

vjuranek commented Apr 29, 2025

I think this one is ready.

@jpechane jpechane merged commit d729445 into debezium:main Apr 30, 2025
42 of 44 checks passed
@jpechane
Copy link
Contributor

jpechane commented Apr 30, 2025

@vjuranek Applied, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vjuranek @jpechane @Naros