Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs/cloud toggle on the first few steps in build-your-first-mo… #878

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

breezyfasano
Copy link
Member

Description & motivation

See this Slack convo for context.
TL;DR: I added Cloud/Core toggle functionality to the first few steps of the process explained on /tutorial/build-your-first-models where previously, it was formatted with just Markdown headers.

Pre-release docs

Is this change related to an unreleased version of dbt?

  • Yes: please
    • update the base branch to next
    • add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
    • add links to the "New and changed documentation" section of the latest Migration Guide
  • No: please ensure the base branch is current
  • Unsure: we'll let you know!

@JKarlavige I just want to call out that when I ran npm install inside website, it updated the package-lock.json and it's going to be committed in this PR. I think it should be fine, but let me know if not!

Copy link
Collaborator

@JKarlavige JKarlavige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@JKarlavige
Copy link
Collaborator

I just want to call out that when I ran npm install inside website, it updated the package-lock.json and it's going to be committed in this PR. I think it should be fine, but let me know if not!

To follow up on this. The package-lock is restructured for me every time I run npm-install. It looks like it only restructures the file, while the dependencies still have the same version and the site behaves the same. So I don't see this as an issue.

@breezyfasano breezyfasano merged commit 02cb75a into current Oct 20, 2021
@breezyfasano breezyfasano deleted the bug/toggle-fix branch October 20, 2021 18:38
@annafil
Copy link
Contributor

annafil commented Oct 20, 2021

Looks great ✅ thank you for fixing this so quickly ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants