Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve dbt-athena profile page #5045

Merged
merged 4 commits into from
Mar 12, 2024
Merged

chore: improve dbt-athena profile page #5045

merged 4 commits into from
Mar 12, 2024

Conversation

nicor88
Copy link
Contributor

@nicor88 nicor88 commented Mar 6, 2024

What are you changing in this pull request and why?

Add some more relevant parameters to work with dbt-athena that were missing in the official dbt page.

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

add dbt-athena parameters to profile
@nicor88 nicor88 requested a review from a team as a code owner March 6, 2024 20:13
Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com 🛑 Canceled (Inspect) Mar 12, 2024 2:25pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Mar 6, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @nicor88 ! thanks for opening this up! will get this merged for you ✨!

@mirnawong1 mirnawong1 enabled auto-merge March 12, 2024 14:14
@mirnawong1 mirnawong1 merged commit d027fdc into dbt-labs:current Mar 12, 2024
4 checks passed
@nicor88 nicor88 deleted the patch-1 branch March 12, 2024 21:06
@nicor88
Copy link
Contributor Author

nicor88 commented Mar 12, 2024

@mirnawong1 thanks 💯 , I totally missed your suggestion and seen them only now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants