Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update new SSO config instructions for generic SAML, Okta, Gsuite and Azure AD #3516

Merged
merged 8 commits into from
Jun 13, 2023
Merged

Update new SSO config instructions for generic SAML, Okta, Gsuite and Azure AD #3516

merged 8 commits into from
Jun 13, 2023

Conversation

ajaythomas
Copy link
Contributor

@ajaythomas ajaythomas commented Jun 13, 2023 •
edited
Loading

What are you changing in this pull request and why?

Updated new SSO config instructions for

  • generic SAML
  • Okta
  • GSuite
  • Azure AD

Added screenshots, moved table containing auth0_uri to main SSO page.

https://dbtlabs.atlassian.net/browse/ENTERPRISE-529

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Added new screenshots for SSO configs
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Rename file names of older screenshots

@welcome
Copy link

welcome bot commented Jun 13, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@netlify
Copy link

netlify bot commented Jun 13, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit c8dfe50
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/6488bf8059747e0008234f7c
😎 Deploy Preview https://deploy-preview-3516--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added new contributor Label for first-time contributors content Improvements or additions to content size: medium This change will take up to a week to address labels Jun 13, 2023
ajaythomas
ajaythomas commented Jun 13, 2023
View reviewed changes
website/docs/docs/cloud/about-cloud/regions-ip-addresses.md
| North America [^1] | AWS us-east-1 (N. Virginia) | cloud.getdbt.com | 52.45.144.63 <br /> 54.81.134.249 <br />52.22.161.231 | ✅ | ✅ | ✅ |
| EMEA [^1] | AWS eu-central-1 (Frankfurt) | emea.dbt.com | 3.123.45.39 <br /> 3.126.140.248 <br /> 3.72.153.148 | ❌ | ❌ | ✅ |
| APAC [^1] | AWS ap-southeast-2 (Sydney)| au.dbt.com | 52.65.89.235 <br /> 3.106.40.33 <br /> 13.239.155.206 <br />| ❌ | ❌ | ✅ |
| Virtual Private dbt or Single tenant | Customized | Customized | Ask [Support](/guides/legacy/getting-help#dbt-cloud-support) for your IPs | ❌ | ❌ | ✅ |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was confusing to add the auth0 uri and SAML specific values in this table. Moved it to website/docs/docs/cloud/manage-access/sso-overview.md

ajaythomas
ajaythomas commented Jun 13, 2023
View reviewed changes
website/snippets/access_url.md Outdated
@@ -1 +1 @@
The following steps use `YOUR_AUTH_URL` and `YOUR_AUDIENCE_URN`, which need to be replaced with the [appropriate Auth URL and Audience URN](docs/cloud/about-cloud/regions-ip-addresses) for your region and plan.
The following steps use `YOUR_AUTH0_URI` and `YOUR_AUTH0_ENTITYID`, which need to be replaced with the [appropriate Auth0 SSO URI and Auth0 Entity ID](docs/cloud/manage-access/set-up-sso-saml-2.0#auth0-multi-tenant-uris) for your region.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am referencing this link that the deploy did not like. How do I build this link @matthewshaver @aaronbini

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should come from here

@ajaythomas ajaythomas force-pushed the enterprise-529-ajay-update-sso-docs-auth0 branch from 31b48a0 to af01497 Compare June 13, 2023 18:48
@ajaythomas ajaythomas marked this pull request as ready for review June 13, 2023 19:08
@ajaythomas ajaythomas requested a review from a team as a code owner June 13, 2023 19:08
@ajaythomas ajaythomas requested a review from saimaddali June 13, 2023 19:08
@matthewshaver matthewshaver enabled auto-merge June 13, 2023 19:12
@matthewshaver matthewshaver merged commit 9749e7a into current Jun 13, 2023
@matthewshaver matthewshaver deleted the enterprise-529-ajay-update-sso-docs-auth0 branch June 13, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver approved these changes

@robotmiller robotmiller Awaiting requested review from robotmiller

@saimaddali saimaddali Awaiting requested review from saimaddali

Assignees
No one assigned
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajaythomas @matthewshaver