Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Engineers + dbt 1.5: Evolving the Craft for Scale #3221

Merged
merged 37 commits into from
May 8, 2023

Conversation

sungchun12
Copy link
Contributor

@sungchun12 sungchun12 commented Apr 19, 2023

What are you changing in this pull request and why?

Adding a new devhub blog post to pair with with the dbt 1.5 release. This adds a human, intimate touch to how dbt can best serve data engineers. More conceptual.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • Technical review from @dbeatty10
    Adding new pages (delete if not applicable):
  • Add page to website/sidebars.js @KiraFuruichi do I need to do this? I didn't notice any of the blog content requiring this step. Edit: Not required
  • Provide a unique filename for the new page

@sungchun12 sungchun12 self-assigned this Apr 19, 2023
@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 747cfc7
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64591a788cb1100008ad41d5
😎 Deploy Preview https://deploy-preview-3221--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added developer blog This content fits on the developer blog. size: medium This change will take up to a week to address labels Apr 19, 2023

authors: [sung_chung, kira_furuichi]

tags: [data ecosystem]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think we should change the tag to either dbt tutorials or analytics craft, dbt product updates!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with dbt product updates!

Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried out all the code examples with dbt-snowflake, and they all worked ✅

Left a handful of suggestions. This is the only blocking suggestion -- the rest are optional:

Two nits:

  • The first example used integer whereas the second used int; this is fine because one is an alias of the other in Snowflake
  • The columns weren't the same between the first example and the second, so it was a little more juggling to follow along with the example

@sungchun12
Copy link
Contributor Author

Two nits:

  • The first example used integer whereas the second used int; this is fine because one is an alias of the other in Snowflake
  • The columns weren't the same between the first example and the second, so it was a little more juggling to follow along with the example

I fixed the two nits!

@sungchun12
Copy link
Contributor Author

@KiraFuruichi @dbeatty10 can you approve so I can officially merge? I made a couple more stylistic edits, spelling updates, and removed the bullet on Doug's 1.5 blog.

@KiraFuruichi KiraFuruichi merged commit ec0d8f1 into current May 8, 2023
@KiraFuruichi KiraFuruichi deleted the blog/evolving-the-craft branch May 8, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer blog This content fits on the developer blog. size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants